netdev - Re: [PATCH] bonding: Always enable vlan tx offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190626232953.GA11474@qmqm.qmqm.pl>
Date:   Thu, 27 Jun 2019 01:29:53 +0200
From:   Michał Mirosław <mirq-linux@...e.qmqm.pl>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     YueHaibing <yuehaibing@...wei.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] bonding: Always enable vlan tx offload

On Wed, Jun 26, 2019 at 06:48:53PM +0200, Jiri Pirko wrote:
> Wed, Jun 26, 2019 at 06:13:38PM CEST, mirq-linux@...e.qmqm.pl wrote:
> >On Wed, Jun 26, 2019 at 04:08:44PM +0800, YueHaibing wrote:
[...]
> >> This patch always enable bonding's vlan tx offload, pass the vlan
> >> packets to the slave devices with vlan tci, let them to handle
> >> vlan implementation.
[...]
> >I can see that bonding driver uses dev_queue_xmit() to pass packets to
> >slave links, but I can't see where in the path it does software fallback
> >for devices without HW VLAN tagging. Generally drivers that don't ever
> >do VLAN offload also ignore vlan_tci presence. Am I missing something
> >here?

> validate_xmit_skb->validate_xmit_vlan

Yes it is. Thanks!

Best Regards,
Michał Mirosław