netdev - RE: [EXT] [PATCH net-next 07/16] qlge: Deduplicate rx buffer queue management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR18MB2697AC678152A26AC676A1B2ABFD0@DM6PR18MB2697.namprd18.prod.outlook.com>
Date:   Thu, 27 Jun 2019 10:02:24 +0000
From:   Manish Chopra <manishc@...vell.com>
To:     Benjamin Poirier <bpoirier@...e.com>,
        GR-Linux-NIC-Dev <GR-Linux-NIC-Dev@...vell.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [EXT] [PATCH net-next 07/16] qlge: Deduplicate rx buffer queue
 management

>  	while (curr_idx != clean_idx) {
> -		lbq_desc = &rx_ring->lbq[curr_idx];
> +		struct qlge_bq_desc *lbq_desc = &rx_ring-
> >lbq.queue[curr_idx];
> 
>  		if (lbq_desc->p.pg_chunk.offset == last_offset)
> -			pci_unmap_page(qdev->pdev, lbq_desc-
> >p.pg_chunk.map,
> +			pci_unmap_page(qdev->pdev, lbq_desc->dma_addr,
>  				       ql_lbq_block_size(qdev),
>  				       PCI_DMA_FROMDEVICE);

In this patch, lbq_desc->dma_addr points to offset in the page. So unmapping is broken within this patch.
Would have been nicer to fix this in the same patch although it might have been taken care in next patches probably.