netdev - [PATCH net-next 0/2] net: ipv4: fix circular-list infinite loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190627120333.12469-1-fw@strlen.de>
Date:   Thu, 27 Jun 2019 14:03:31 +0200
From:   Florian Westphal <fw@...len.de>
To:     <netdev@...r.kernel.org>
Cc:     ranro@...lanox.com, tariqt@...lanox.com
Subject: [PATCH net-next 0/2] net: ipv4: fix circular-list infinite loop

Tariq and Ran reported a regression caused by net-next commit
2638eb8b50cf ("net: ipv4: provide __rcu annotation for ifa_list").

This happens when net.ipv4.conf.$dev.promote_secondaries sysctl is
enabled -- we can arrange for ifa->next to point at ifa, so next
process that tries to walk the list loops forever.

Fix this and extend rtnetlink.sh with a small test case for this.

Florian Westphal (2):
      net: ipv4: fix infinite loop on secondary addr promotion
      selftests: rtnetlink: add small test case with 'promote_secondaries' enabled

 net/ipv4/devinet.c                       |    3 ++-
 tools/testing/selftests/net/rtnetlink.sh |   20 ++++++++++++++++++++
 2 files changed, 22 insertions(+), 1 deletion(-)