netdev - Re: [RFC, PATCH 2/2, net-next] net: netsec: add XDP support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190627122430.GA32659@apalos>
Date:   Thu, 27 Jun 2019 15:24:30 +0300
From:   Ilias Apalodimas <ilias.apalodimas@...aro.org>
To:     Jesper Dangaard Brouer <brouer@...hat.com>
Cc:     netdev@...r.kernel.org, jaswinder.singh@...aro.org,
        ard.biesheuvel@...aro.org, bjorn.topel@...el.com,
        magnus.karlsson@...el.com, daniel@...earbox.net, ast@...nel.org,
        makita.toshiaki@....ntt.co.jp, jakub.kicinski@...ronome.com,
        john.fastabend@...il.com, davem@...emloft.net
Subject: Re: [RFC, PATCH 2/2, net-next] net: netsec: add XDP support

On Thu, Jun 27, 2019 at 02:23:05PM +0200, Jesper Dangaard Brouer wrote:
> On Tue, 25 Jun 2019 18:06:19 +0300
> Ilias Apalodimas <ilias.apalodimas@...aro.org> wrote:
> 
> > @@ -609,6 +639,9 @@ static bool netsec_clean_tx_dring(struct netsec_priv *priv)
> >  	int tail = dring->tail;
> >  	int cnt = 0;
> >  
> > +	if (dring->is_xdp)
> > +		spin_lock(&dring->lock);
> > +
> >  	pkts = 0;
> >  	bytes = 0;
> >  	entry = dring->vaddr + DESC_SZ * tail;
> > @@ -622,16 +655,24 @@ static bool netsec_clean_tx_dring(struct netsec_priv *priv)
> >  		eop = (entry->attr >> NETSEC_TX_LAST) & 1;
> >  		dma_rmb();
> >  
> > -		dma_unmap_single(priv->dev, desc->dma_addr, desc->len,
> > -				 DMA_TO_DEVICE);
> > -		if (eop) {
> > -			pkts++;
> > +		if (!eop)
> > +			goto next;
> > +
> > +		if (desc->buf_type == TYPE_NETSEC_SKB) {
> > +			dma_unmap_single(priv->dev, desc->dma_addr, desc->len,
> > +					 DMA_TO_DEVICE);
> 
> I don't think this is correct.  If I read the code correctly, you will
> miss the DMA unmap for !eop packets.
> 

You are reading it correct, thanks for catching this.
I'll fix it on the proper patch

Thanks
/Ilias