netdev - Re: [PATCH net-next v2 1/4] net/sched: Introduce action ct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190627.125339.707372206595841703.davem@davemloft.net>
Date:   Thu, 27 Jun 2019 12:53:39 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     paulb@...lanox.com
Cc:     jiri@...lanox.com, roid@...lanox.com, yossiku@...lanox.com,
        ozsh@...lanox.com, marcelo.leitner@...il.com,
        netdev@...r.kernel.org, aconole@...hat.com, wangzhike@...com,
        ronye@...lanox.com, nst-kernel@...hat.com,
        john.hurley@...ronome.com, simon.horman@...ronome.com,
        jpettit@....org
Subject: Re: [PATCH net-next v2 1/4] net/sched: Introduce action ct

From: Paul Blakey <paulb@...lanox.com>
Date: Thu, 20 Jun 2019 16:42:18 +0300

> +struct tcf_ct_params {
 ...
> +	struct rcu_head rcu;
> +
> +};

Please get ride of that empty line after the 'rcu' member.

> +	switch (skb->protocol) {
> +	case htons(ETH_P_IP):
> +		family = NFPROTO_IPV4;
> +		break;
> +	case htons(ETH_P_IPV6):
> +		family = NFPROTO_IPV6;
> +		break;
> +	default:
> +	break;

Break statement is not indented properly.

> +static __net_init int ct_init_net(struct net *net)
> +{
> +	struct tc_ct_action_net *tn = net_generic(net, ct_net_id);
> +	unsigned int n_bits = FIELD_SIZEOF(struct tcf_ct_params, labels) * 8;

Reverse christmas tree here please.