netdev - Re: [PATCH 2/6 bpf-next] Clean up xsk reuseq API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190627153856.1f4d4709@cakuba.netronome.com>
Date:   Thu, 27 Jun 2019 15:38:56 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Jonathan Lemon <jonathan.lemon@...il.com>
Cc:     <netdev@...r.kernel.org>, <bjorn.topel@...el.com>,
        <magnus.karlsson@...el.com>, <saeedm@...lanox.com>,
        <maximmi@...lanox.com>, <brouer@...hat.com>, <kernel-team@...com>
Subject: Re: [PATCH 2/6 bpf-next] Clean up xsk reuseq API

On Thu, 27 Jun 2019 15:08:32 -0700, Jonathan Lemon wrote:
> The reuseq is actually a recycle stack, only accessed from the kernel side.
> Also, the implementation details of the stack should belong to the umem
> object, and not exposed to the caller.
> 
> Clean up and rename for consistency in preparation for the next patch.
> 
> Signed-off-by: Jonathan Lemon <jonathan.lemon@...il.com>

Prepare/swap is to cater to how drivers should be written - being able
to allocate resources independently of those currently used.  Allowing
for changing ring sizes and counts on the fly.  This patch makes it
harder to write drivers in the way we are encouraging people to.

IOW no, please don't do this.