netdev - Re: [PATCH v2 net-next 0/3] Better PHYLINK compliance for SJA1105 DSA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190628100542.hmzqnp4bsnkikcvv@shell.armlinux.org.uk>
Date:   Fri, 28 Jun 2019 11:05:42 +0100
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     f.fainelli@...il.com, vivien.didelot@...il.com, andrew@...n.ch,
        davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 0/3] Better PHYLINK compliance for SJA1105 DSA

On Fri, Jun 28, 2019 at 12:46:34AM +0300, Vladimir Oltean wrote:
> After discussing with Russell King, it appears this driver is making a
> few confusions and not performing some checks for consistent operation.
> 
> Changes in v2:
> - Removed redundant print in the phylink_validate callback (in 2/3).
> 
> Vladimir Oltean (3):
>   net: dsa: sja1105: Don't check state->link in phylink_mac_config
>   net: dsa: sja1105: Check for PHY mode mismatches with what PHYLINK
>     reports
>   net: dsa: sja1105: Mark in-band AN modes not supported for PHYLINK
> 
>  drivers/net/dsa/sja1105/sja1105_main.c | 56 +++++++++++++++++++++++++-
>  1 file changed, 54 insertions(+), 2 deletions(-)

Thanks.  For the whole series:

Acked-by: Russell King <rmk+kernel@...linux.org.uk>

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up