lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 28 Jun 2019 12:17:15 -0600 From: Rob Herring <robh+dt@...nel.org> To: Maxime Ripard <maxime.ripard@...tlin.com> Cc: Mark Rutland <mark.rutland@....com>, Frank Rowand <frowand.list@...il.com>, "David S . Miller" <davem@...emloft.net>, Chen-Yu Tsai <wens@...e.org>, Maxime Coquelin <mcoquelin.stm32@...il.com>, Alexandre Torgue <alexandre.torgue@...com>, netdev <netdev@...r.kernel.org>, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@...ts.infradead.org>, devicetree@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, Maxime Chevallier <maxime.chevallier@...tlin.com>, Antoine Ténart <antoine.tenart@...tlin.com>, Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>, Heiner Kallweit <hkallweit1@...il.com> Subject: Re: [PATCH v4 03/13] dt-bindings: net: Add a YAML schemas for the generic MDIO options On Fri, Jun 28, 2019 at 7:46 AM Maxime Ripard <maxime.ripard@...tlin.com> wrote: > > On Thu, Jun 27, 2019 at 10:06:57AM -0600, Rob Herring wrote: > > On Thu, Jun 27, 2019 at 9:57 AM Maxime Ripard <maxime.ripard@...tlin.com> wrote: > > > > > + > > > > > + reset-gpios = <&gpio2 5 1>; > > > > > + reset-delay-us = <2>; > > > > > + > > > > > + ethphy0: ethernet-phy@1 { > > > > > + reg = <1>; > > > > > > > > Need a child node schema to validate the unit-address and reg property. > > > > > > This should be already covered by the ethernet-phy.yaml schemas > > > earlier in this series. > > > > Partially, yes. > > > > > Were you expecting something else? > > > > That would not prevent having a child node such as 'foo {};' or > > 'foo@bad {};'. It would also not check valid nodes named something > > other than 'ethernet-phy'. > > Right, but listing the nodes won't either, since we can't enable > additionalProperties in that schema. So any node that wouldn't match > ethernet-phy@.* wouldn't be validated, but wouldn't generate a warning > either. Perhaps I wasn't clear, but it was missing or incorrect 'reg' property and unit-address format checks that I was thinking about. Just like we have for SPI. Rob
Powered by blists - more mailing lists