netdev - Re: [PATCH v2 bpf-next 3/4] selftests/bpf: convert selftests using BTF-defined maps to new syntax

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AC70CA4A-F925-431B-9860-70E7B190AA84@fb.com>
Date:   Fri, 28 Jun 2019 18:25:55 +0000
From:   Song Liu <songliubraving@...com>
To:     Andrii Nakryiko <andriin@...com>
CC:     Andrii Nakryiko <andrii.nakryiko@...il.com>,
        Alexei Starovoitov <ast@...com>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 bpf-next 3/4] selftests/bpf: convert selftests using
 BTF-defined maps to new syntax



> On Jun 28, 2019, at 8:25 AM, Andrii Nakryiko <andriin@...com> wrote:
> 
> Convert all the existing selftests that are already using BTF-defined
> maps to use new syntax (with no static data initialization).
> 
> Signed-off-by: Andrii Nakryiko <andriin@...com>

Acked-by: Song Liu <songliubraving@...com>

This looks cleaner!

> ---
> tools/testing/selftests/bpf/progs/bpf_flow.c  | 28 +++----
> .../testing/selftests/bpf/progs/netcnt_prog.c | 20 ++---
> .../selftests/bpf/progs/socket_cookie_prog.c  | 13 ++-
> .../selftests/bpf/progs/test_btf_newkv.c      | 13 ++-
> .../bpf/progs/test_get_stack_rawtp.c          | 39 ++++-----
> .../selftests/bpf/progs/test_global_data.c    | 37 ++++-----
> tools/testing/selftests/bpf/progs/test_l4lb.c | 65 ++++++---------
> .../selftests/bpf/progs/test_l4lb_noinline.c  | 65 ++++++---------
> .../selftests/bpf/progs/test_map_lock.c       | 26 +++---
> .../bpf/progs/test_select_reuseport_kern.c    | 67 ++++++---------
> .../bpf/progs/test_send_signal_kern.c         | 26 +++---
> .../bpf/progs/test_sock_fields_kern.c         | 78 +++++++-----------
> .../selftests/bpf/progs/test_spin_lock.c      | 36 ++++-----
> .../bpf/progs/test_stacktrace_build_id.c      | 55 +++++--------
> .../selftests/bpf/progs/test_stacktrace_map.c | 52 +++++-------
> .../selftests/bpf/progs/test_tcp_estats.c     | 13 ++-
> .../selftests/bpf/progs/test_tcpbpf_kern.c    | 26 +++---
> .../selftests/bpf/progs/test_tcpnotify_kern.c | 28 +++----
> tools/testing/selftests/bpf/progs/test_xdp.c  | 26 +++---
> .../selftests/bpf/progs/test_xdp_noinline.c   | 81 +++++++------------
> 20 files changed, 300 insertions(+), 494 deletions(-)