netdev - Re: [PATCH 1/1] net: dsa: b53: Disable all ports on setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190628152443.GB2883@t480s.localdomain>
Date:   Fri, 28 Jun 2019 15:24:43 -0400
From:   Vivien Didelot <vivien.didelot@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Benedikt Spranger <b.spranger@...utronix.de>,
        netdev@...r.kernel.org,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Kurt Kanzenbach <kurt@...utronix.de>,
        Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH 1/1] net: dsa: b53: Disable all ports on setup

On Fri, 28 Jun 2019 10:23:06 -0700, Florian Fainelli <f.fainelli@...il.com> wrote:
> On 6/28/19 9:58 AM, Benedikt Spranger wrote:
> > A b53 device may configured through an external EEPROM like the switch
> > device on the Lamobo R1 router board. The configuration of a port may
> > therefore differ from the reset configuration of the switch.
> > 
> > The switch configuration reported by the DSA subsystem is different until
> > the port is configured by DSA i.e. a port can be active, while the DSA
> > subsystem reports the port is inactive. Disable all ports and not only
> > the unused ones to put all ports into a well defined state.
> > 
> > Signed-off-by: Benedikt Spranger <b.spranger@...utronix.de>
> 
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
> 
> Makes sense, in fact, that should probably be moved to the DSA core at
> some point (wink wink Vivien).

On it!