netdev - Re: [PATCH net-next] af_packet: convert pending frame counter to atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 29 Jun 2019 04:46:19 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Neil Horman <nhorman@...driver.com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org,
        Neil Horman <nhorman@...driver.com>,
        "David S. Miller" <davem@...emloft.net>,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net-next] af_packet: convert pending frame counter to
 atomic_t

Hi Neil,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Neil-Horman/af_packet-convert-pending-frame-counter-to-atomic_t/20190629-032437
config: x86_64-randconfig-x007-201925 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-9) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   net/packet/af_packet.c: In function 'packet_read_pending':
>> net/packet/af_packet.c:1168:1: warning: no return statement in function returning non-void [-Wreturn-type]
    }
    ^

vim +1168 net/packet/af_packet.c

b0138408 Daniel Borkmann 2014-01-15  1164  
b0138408 Daniel Borkmann 2014-01-15  1165  static unsigned int packet_read_pending(const struct packet_ring_buffer *rb)
b0138408 Daniel Borkmann 2014-01-15  1166  {
5e9e5c90 Neil Horman     2019-06-28  1167  	atomic_read(&rb->pending_refcnt);
b0138408 Daniel Borkmann 2014-01-15 @1168  }
b0138408 Daniel Borkmann 2014-01-15  1169  

:::::: The code at line 1168 was first introduced by commit
:::::: b013840810c221f2b0cf641d01531526052dc1fb packet: use percpu mmap tx frame pending refcount

:::::: TO: Daniel Borkmann <dborkman@...hat.com>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (32812 bytes)