netdev - Re: [PATCHv2 next 0/3] blackhole device to invalidate dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAF2d9jgr-pPm2p=TvLqUAa6v65vk82tXoA8XUeqWFQ7r8sa=pw@mail.gmail.com>
Date:   Fri, 28 Jun 2019 15:39:29 -0700
From:   Mahesh Bandewar (महेश बंडेवार) 
        <maheshb@...gle.com>
To:     Michael Chan <michael.chan@...adcom.com>
Cc:     Netdev <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        David Miller <davem@...emloft.net>,
        Daniel Axtens <dja@...ens.net>,
        Mahesh Bandewar <mahesh@...dewar.net>
Subject: Re: [PATCHv2 next 0/3] blackhole device to invalidate dst

On Fri, Jun 28, 2019 at 11:22 AM Michael Chan <michael.chan@...adcom.com> wrote:
>
> On Thu, Jun 27, 2019 at 12:42 PM Mahesh Bandewar <maheshb@...gle.com> wrote:
>
> > However, Michael Chan <michael.chan@...adcom.com> had a setup
> > where these fixes helped him mitigate the issue and not cause
> > the crash.
> >
>
> Our lab has finished testing these patches.  The patches work in the
> sense that no oversize packets are now passed to the driver with the
> patches applied.  But I'm not seeing these bad packets reaching the
> blackhole device and getting dropped there.  So they get dropped in
> some other code paths.  I believe we saw the same results with your
> earlier patches.
>
Thanks Michael for confirmation. I would say that is WAI. With the MTU
that low, I don't think .ndo_xmit for this device would ever be
triggered.