netdev - Re: [PATCH v3] bpf: fix uapi bpf_prog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <db429758-7d5a-4b5c-0bb6-2663dfffac37@iogearbox.net>
Date:   Sat, 29 Jun 2019 01:37:03 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Baruch Siach <baruch@...s.co.il>,
        Alexei Starovoitov <ast@...nel.org>
Cc:     Martin KaFai Lau <kafai@...com>, Song Liu <songliubraving@...com>,
        Yonghong Song <yhs@...com>, netdev@...r.kernel.org,
        bpf@...r.kernel.org, "Dmitry V . Levin" <ldv@...linux.org>,
        Arnd Bergmann <arnd@...db.de>, linux-arch@...r.kernel.org,
        Jiri Olsa <jolsa@...nel.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH v3] bpf: fix uapi bpf_prog_info fields alignment

On 06/28/2019 06:08 AM, Baruch Siach wrote:
> Merge commit 1c8c5a9d38f60 ("Merge
> git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next") undid the
> fix from commit 36f9814a494 ("bpf: fix uapi hole for 32 bit compat
> applications") by taking the gpl_compatible 1-bit field definition from
> commit b85fab0e67b162 ("bpf: Add gpl_compatible flag to struct
> bpf_prog_info") as is. That breaks architectures with 16-bit alignment
> like m68k. Add 31-bit pad after gpl_compatible to restore alignment of
> following fields.
> 
> Thanks to Dmitry V. Levin his analysis of this bug history.
> 
> Cc: Jiri Olsa <jolsa@...nel.org>
> Cc: Daniel Borkmann <daniel@...earbox.net>
> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> Signed-off-by: Baruch Siach <baruch@...s.co.il>

Applied, thanks!