netdev - Re: [PATCH v2] net: dsa: mv88e6xxx: wait after reset deactivation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190629.122155.104888078125933248.davem@davemloft.net>
Date:   Sat, 29 Jun 2019 12:21:55 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     baruch@...s.co.il
Cc:     andrew@...n.ch, vivien.didelot@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2] net: dsa: mv88e6xxx: wait after reset deactivation

From: Baruch Siach <baruch@...s.co.il>
Date: Thu, 27 Jun 2019 21:17:39 +0300

> Add a 1ms delay after reset deactivation. Otherwise the chip returns
> bogus ID value. This is observed with 88E6390 (Peridot) chip.
> 
> Signed-off-by: Baruch Siach <baruch@...s.co.il>
> ---
> v2: Address Andrew Lunn's comments:
>   Use usleep_range.
>   Delay only when reset line is valid.

Applied and queuedu up for -stable, thanks.