netdev - Re: [PATCH net-next v3 4/4] gve: Add ethtool support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190629.101934.129593453807760399.davem@davemloft.net>
Date:   Sat, 29 Jun 2019 10:19:34 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     csully@...gle.com
Cc:     netdev@...r.kernel.org, sagis@...gle.com, jonolson@...gle.com,
        willemb@...gle.com, lrizzo@...gle.com
Subject: Re: [PATCH net-next v3 4/4] gve: Add ethtool support

From: Catherine Sullivan <csully@...gle.com>
Date: Fri, 28 Jun 2019 16:07:33 -0700

> +void gve_get_channels(struct net_device *netdev, struct ethtool_channels *cmd)
 ...
> +int gve_set_channels(struct net_device *netdev, struct ethtool_channels *cmd)
 ...
> +void gve_get_ringparam(struct net_device *netdev,
> +		       struct ethtool_ringparam *cmd)
 ...
> +int gve_user_reset(struct net_device *netdev, u32 *flags)
 ...

Please mark these static as per the kbuild robot feedback.

Thank you.