netdev - Re: [PATCH v2 net-next 04/19] ionic: Add basic lif support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190629114526.4da68321@cakuba.netronome.com>
Date:   Sat, 29 Jun 2019 11:45:26 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Shannon Nelson <snelson@...sando.io>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 04/19] ionic: Add basic lif support

On Fri, 28 Jun 2019 14:39:19 -0700, Shannon Nelson wrote:
> @@ -64,4 +66,49 @@ int ionic_debugfs_add_ident(struct ionic *ionic)
>  				   ionic, &identity_fops) ? 0 : -ENOTSUPP;
>  }
>  
> +int ionic_debugfs_add_sizes(struct ionic *ionic)
> +{
> +	debugfs_create_u32("nlifs", 0400, ionic->dentry,
> +			   (u32 *)&ionic->ident.dev.nlifs);
> +	debugfs_create_u32("nintrs", 0400, ionic->dentry, &ionic->nintrs);
> +
> +	debugfs_create_u32("ntxqs_per_lif", 0400, ionic->dentry,
> +			   (u32 *)&ionic->ident.lif.eth.config.queue_count[IONIC_QTYPE_TXQ]);
> +	debugfs_create_u32("nrxqs_per_lif", 0400, ionic->dentry,
> +			   (u32 *)&ionic->ident.lif.eth.config.queue_count[IONIC_QTYPE_RXQ]);

Are these __le32s?  Does the driver build cleanly with W=1 C=1?

> +	return 0;
> +}