netdev - Re: [PATCH v2 net-next 04/19] ionic: Add basic lif support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3ba46066-8e52-f7cc-30f1-2560890a23b7@pensando.io>
Date:   Mon, 1 Jul 2019 11:00:23 -0700
From:   Shannon Nelson <snelson@...sando.io>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 04/19] ionic: Add basic lif support



On 6/29/19 11:45 AM, Jakub Kicinski wrote:
> On Fri, 28 Jun 2019 14:39:19 -0700, Shannon Nelson wrote:
>> @@ -64,4 +66,49 @@ int ionic_debugfs_add_ident(struct ionic *ionic)
>>   				   ionic, &identity_fops) ? 0 : -ENOTSUPP;
>>   }
>>   
>> +int ionic_debugfs_add_sizes(struct ionic *ionic)
>> +{
>> +	debugfs_create_u32("nlifs", 0400, ionic->dentry,
>> +			   (u32 *)&ionic->ident.dev.nlifs);
>> +	debugfs_create_u32("nintrs", 0400, ionic->dentry, &ionic->nintrs);
>> +
>> +	debugfs_create_u32("ntxqs_per_lif", 0400, ionic->dentry,
>> +			   (u32 *)&ionic->ident.lif.eth.config.queue_count[IONIC_QTYPE_TXQ]);
>> +	debugfs_create_u32("nrxqs_per_lif", 0400, ionic->dentry,
>> +			   (u32 *)&ionic->ident.lif.eth.config.queue_count[IONIC_QTYPE_RXQ]);
> Are these __le32s?  Does the driver build cleanly with W=1 C=1?

Aside from a couple of "expression using sizeof(void)" messages that I 
haven't been able to fully clean out, yes, the driver builds pretty 
clean with sparse.  In this particular case, I think the typecast stops 
the complaint that you are expecting here.  But yes, these would be 
better off with le32_to_cpu().

sln

>
>> +	return 0;
>> +}