netdev - Re: [PATCH bpf v6 0/2] xdp: fix hang while unregistering device bound to xdp socket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ae128ab7-0983-921e-7e56-7f42cb419113@iogearbox.net>
Date:   Wed, 3 Jul 2019 17:05:08 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Ilya Maximets <i.maximets@...sung.com>, netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, bpf@...r.kernel.org,
        xdp-newbies@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Björn Töpel <bjorn.topel@...el.com>,
        Magnus Karlsson <magnus.karlsson@...el.com>,
        Jonathan Lemon <jonathan.lemon@...il.com>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>
Subject: Re: [PATCH bpf v6 0/2] xdp: fix hang while unregistering device bound
 to xdp socket

On 06/28/2019 10:04 AM, Ilya Maximets wrote:
> Version 6:
> 
>     * Better names for socket state.
> 
> Version 5:
> 
>     * Fixed incorrect handling of rtnl_lock.
> 
> Version 4:
> 
>     * 'xdp_umem_clear_dev' exposed to be used while unregistering.
>     * Added XDP socket state to track if resources already unbinded.
>     * Splitted in two fixes.
> 
> Version 3:
> 
>     * Declaration lines ordered from longest to shortest.
>     * Checking of event type moved to the top to avoid unnecessary
>       locking.
> 
> Version 2:
> 
>     * Completely re-implemented using netdev event handler.
> 
> Ilya Maximets (2):
>   xdp: hold device for umem regardless of zero-copy mode
>   xdp: fix hang while unregistering device bound to xdp socket
> 
>  include/net/xdp_sock.h |  5 +++
>  net/xdp/xdp_umem.c     | 21 +++++-----
>  net/xdp/xdp_umem.h     |  1 +
>  net/xdp/xsk.c          | 87 ++++++++++++++++++++++++++++++++++++------
>  4 files changed, 93 insertions(+), 21 deletions(-)
> 

Applied, thanks!