netdev - Re: [Patch net] bonding: validate ip header before check IPPROTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190703.132655.1832823550319483737.davem@davemloft.net>
Date:   Wed, 03 Jul 2019 13:26:55 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xiyou.wangcong@...il.com
Cc:     netdev@...r.kernel.org,
        syzbot+e5be16aa39ad6e755391@...kaller.appspotmail.com,
        j.vosburgh@...il.com, vfalico@...il.com, andy@...yhouse.net
Subject: Re: [Patch net] bonding: validate ip header before check
 IPPROTO_IGMP

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Mon,  1 Jul 2019 20:40:24 -0700

> bond_xmit_roundrobin() checks for IGMP packets but it parses
> the IP header even before checking skb->protocol.
> 
> We should validate the IP header with pskb_may_pull() before
> using iph->protocol.
> 
> Reported-and-tested-by: syzbot+e5be16aa39ad6e755391@...kaller.appspotmail.com
> Fixes: a2fd940f4cff ("bonding: fix broken multicast with round-robin mode")
> Cc: Jay Vosburgh <j.vosburgh@...il.com>
> Cc: Veaceslav Falico <vfalico@...il.com>
> Cc: Andy Gospodarek <andy@...yhouse.net>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Applied and queued up for -stable, thanks.