netdev - Re: [PATCH net-next 0/3 v2] macsec: a few cleanups in the receive path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190703.134228.1805959660993963992.davem@davemloft.net>
Date:   Wed, 03 Jul 2019 13:42:28 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ast@...dv.de
Cc:     netdev@...r.kernel.org, sd@...asysnail.net
Subject: Re: [PATCH net-next 0/3 v2] macsec: a few cleanups in the receive
 path

From: Andreas Steinmetz <ast@...dv.de>
Date: Tue, 02 Jul 2019 22:49:54 +0200

> This patchset removes some unnecessary code in the receive path of the
> macsec driver, and re-indents the error handling after calling
> macsec_decrypt to make the post-processing clearer.
> 
> This is a combined effort of Sabrina Dubroca <sd@...asysnail.net> and me.
> 
> Change in 3/3:
> 
> The patch now only moves the IS_ERR(skb) case under the block where
> macsec_decrypt() is called, but not the call to macsec_post_decrypt().
> 

I really don't like these changes, especially patches #1 and #2.

Like Willem I don't think you can blindly remove the share check like
this (and you ignored his feedback about this from v1 it seems), and
the removal is *pskb assignment to NULL is undoing defensive
programming.

I'm not applying this series.