netdev - Re: [PATCH net-next 0/2] Mellanox, mlx5 devlink versions query

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190703.134935.540885263693556753.davem@davemloft.net>
Date:   Wed, 03 Jul 2019 13:49:35 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     saeedm@...lanox.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next 0/2] Mellanox, mlx5 devlink versions query

From: David Miller <davem@...emloft.net>
Date: Wed, 03 Jul 2019 13:47:00 -0700 (PDT)

> From: Saeed Mahameed <saeedm@...lanox.com>
> Date: Tue, 2 Jul 2019 23:55:07 +0000
> 
>> This humble 2 patch series from Shay adds the support for devlink fw
>> versions query to mlx5 driver.
>> 
>> In the first patch we implement the needed fw commands to support this
>> feature.
>> In the 2nd patch we implement the devlink callbacks themselves.
>> 
>> I am not sending this as a pull request since i am not sure when my next
>> pull request is going to be ready, and these two patches are straight
>> forward net-next patches.
> 
> Series applied to net-next, thanks.

This doesn't build, there is some dependency...

[davem@...alhost net-next]$ make -s -j14
In file included from ./include/linux/mlx5/driver.h:51,
                 from drivers/net/ethernet/mellanox/mlx5/core/fw.c:33:
drivers/net/ethernet/mellanox/mlx5/core/fw.c: In function ‘mlx5_reg_mcqi_query’:
./include/linux/mlx5/device.h:68:36: error: invalid application of ‘sizeof’ to incomplete type ‘union mlx5_ifc_mcqi_reg_data_bits’
 #define MLX5_UN_SZ_DW(typ) (sizeof(union mlx5_ifc_##typ##_bits) / 32)
                                    ^~~~~