netdev - Re: [PATCH net-next v2] net: ethernet: mediatek: Fix overlapping capability bits.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190704.123800.788232773059713763.davem@davemloft.net>
Date:   Thu, 04 Jul 2019 12:38:00 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     opensource@...rst.com
Cc:     sean.wang@...iatek.com, f.fainelli@...il.com,
        linux@...linux.org.uk, matthias.bgg@...il.com, andrew@...n.ch,
        vivien.didelot@...il.com, frank-w@...lic-files.de,
        netdev@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        linux-mips@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: ethernet: mediatek: Fix overlapping
 capability bits.

From: René van Dorst <opensource@...rst.com>
Date: Wed,  3 Jul 2019 20:42:04 +0200

> Both MTK_TRGMII_MT7621_CLK and MTK_PATH_BIT are defined as bit 10.
> 
> This can causes issues on non-MT7621 devices which has the
> MTK_PATH_BIT(MTK_ETH_PATH_GMAC1_RGMII) and MTK_TRGMII capability set.
> The wrong TRGMII setup code can be executed. The current wrongly executed
> code doesn’t do any harm on MT7623 and the TRGMII setup for the MT7623
> SOC side is done in MT7530 driver So it wasn’t noticed in the test.
> 
> Move all capability bits in one enum so that they are all unique and easy
> to expand in the future.
> 
> Because mtk_eth_path enum is merged in to mkt_eth_capabilities, the
> variable path value is no longer between 0 to number of paths,
> mtk_eth_path_name can’t be used anymore in this form. Convert the
> mtk_eth_path_name array to a function to lookup the pathname.
> 
> The old code walked thru the mtk_eth_path enum, which is also merged
> with mkt_eth_capabilities. Expand array mtk_eth_muxc so it can store the
> name and capability bit of the mux. Convert the code so it can walk thru
> the mtk_eth_muxc array.
> 
> Fixes: 8efaa653a8a5 ("net: ethernet: mediatek: Add MT7621 TRGMII mode
> support")

Please in the future do not split Fixes: tags onto mutliple lines, it
must be one contiguous line no matter how long.  I fixed it up this
time.

> Signed-off-by: René van Dorst <opensource@...rst.com>

Applied, thank you.