netdev - Re: [PATCH net-next v6 5/5] selftests: tc-tests: actions: add MPLS tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <851rz4o626.fsf@mojatatu.com>
Date:   Fri, 05 Jul 2019 11:27:13 -0400
From:   Roman Mashak <mrv@...atatu.com>
To:     John Hurley <john.hurley@...ronome.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, jiri@...lanox.com,
        xiyou.wangcong@...il.com, dsahern@...il.com,
        willemdebruijn.kernel@...il.com, dcaratti@...hat.com,
        simon.horman@...ronome.com, jakub.kicinski@...ronome.com,
        oss-drivers@...ronome.com
Subject: Re: [PATCH net-next v6 5/5] selftests: tc-tests: actions: add MPLS tests

John Hurley <john.hurley@...ronome.com> writes:

> Add a new series of selftests to verify the functionality of act_mpls in
> TC.
>
> Signed-off-by: John Hurley <john.hurley@...ronome.com>
> Reviewed-by: Simon Horman <simon.horman@...ronome.com>
> Acked-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> ---
>  tools/testing/selftests/tc-testing/config          |   1 +
>  .../tc-testing/tc-tests/actions/mpls.json          | 812 +++++++++++++++++++++
>  2 files changed, 813 insertions(+)
>  create mode 100644 tools/testing/selftests/tc-testing/tc-tests/actions/mpls.json
>

[...]

Thanks for contributing tdc test cases. It would make sense to add tests
for max values and exceeding max allowed values, e.g. for mpls labels,
ttl and such, as we already do for other actions.