netdev - Re: [PATCH net-next 1/3] ipv4: Multipath hashing on inner L3 needs to consider inner IPv6 pkts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190705.151922.1652415160614892448.davem@davemloft.net>
Date:   Fri, 05 Jul 2019 15:19:22 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ssuryaextr@...il.com
Cc:     netdev@...r.kernel.org, idosch@...sch.org,
        nikolay@...ulusnetworks.com, dsahern@...il.com
Subject: Re: [PATCH net-next 1/3] ipv4: Multipath hashing on inner L3 needs
 to consider inner IPv6 pkts

From: Stephen Suryaputra <ssuryaextr@...il.com>
Date: Wed,  3 Jul 2019 11:19:32 -0400

> Commit 363887a2cdfe ("ipv4: Support multipath hashing on inner IP pkts
> for GRE tunnel") supports multipath policy value of 2, Layer 3 or inner
> Layer 3 if present, but it only considers inner IPv4. There is a use
> case of IPv6 over GRE over IPv4, thus add the ability to hash on inner
> IPv6 addresses.
> 
> Fixes: 363887a2cdfe ("ipv4: Support multipath hashing on inner IP pkts for GRE tunnel")
> Signed-off-by: Stephen Suryaputra <ssuryaextr@...il.com>

The wording in this commit message is very confusing.

If you say "IPv6 over GRE over IPv4" then IPv6 is the outer protocol
type, not the inner one.

You need to clarify or reword this commit message so that it is
understandable and matches the logic.

Thanks.