netdev - Re: [PATCH] Bluetooth: hidp: NUL terminate a string in the compat ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <3D402D33-37D1-4FAA-B7C0-2D9C2CC5C2DE@holtmann.org>
Date:   Sat, 6 Jul 2019 13:08:13 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        Mark Salyzyn <salyzyn@...roid.com>,
        Andrea Parri <andrea.parri@...rulasolutions.com>,
        linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org,
        Allen Pais <allen.pais@...cle.com>,
        Young Xiao <YangX92@...mail.com>
Subject: Re: [PATCH] Bluetooth: hidp: NUL terminate a string in the compat
 ioctl

Hi Dan,

> This change is similar to commit a1616a5ac99e ("Bluetooth: hidp: fix
> buffer overflow") but for the compat ioctl.  We take a string from the
> user and forgot to ensure that it's NUL terminated.
> 
> I have also changed the strncpy() in to strscpy() in hidp_setup_hid().
> The difference is the strncpy() doesn't necessarily NUL terminate the
> destination string.  Either change would fix the problem but it's nice
> to take a belt and suspenders approach and do both.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
> net/bluetooth/hidp/core.c | 2 +-
> net/bluetooth/hidp/sock.c | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel