netdev - Re: [RFC PATCH net-next 0/6] tc-taprio offload for SJA1105 DSA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 7 Jul 2019 23:28:24 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Vinicius Costa Gomes <vinicius.gomes@...el.com>,
        vedang.patel@...el.com, Richard Cochran <richardcochran@...il.com>,
        weifeng.voon@...el.com, jiri@...lanox.com, m-karicheri2@...com,
        Jose.Abreu@...opsys.com, ilias.apalodimas@...aro.org,
        netdev <netdev@...r.kernel.org>
Subject: Re: [RFC PATCH net-next 0/6] tc-taprio offload for SJA1105 DSA

On Sun, 7 Jul 2019 at 20:47, Andrew Lunn <andrew@...n.ch> wrote:
>
> > - Configuring the switch over SPI cannot apparently be done from this
> >   ndo_setup_tc callback because it runs in atomic context. I also have
> >   some downstream patches to offload tc clsact matchall with mirred
> >   action, but in that case it looks like the atomic context restriction
> >   does not apply.
>
> There have been similar problems in the past. We can probably have the
> DSA layer turn it into a notifier. Look at the dsa_port_mdb_*
> functions for example.
>
>           Andrew

Ok, thanks. I thought the dsa_port_notify functions are just to be
called from switchdev. I'm still not sure I fully understand, but I'll
try to switch to that in v2 and see what happens.

-Vladimir