netdev - Re: [PATCH 1/2] proc: revalidate directories created with proc_net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190707080351.GA6236@avx2>
Date:   Sun, 7 Jul 2019 11:03:51 +0300
From:   Alexey Dobriyan <adobriyan@...il.com>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        Per.Hallsmark@...driver.com
Subject: Re: [PATCH 1/2] proc: revalidate directories created with
 proc_net_mkdir()

On Sun, Jul 07, 2019 at 02:03:20AM +0100, Al Viro wrote:
> On Sat, Jul 06, 2019 at 07:52:02PM +0300, Alexey Dobriyan wrote:
> > +struct proc_dir_entry *_proc_mkdir(const char *name, umode_t mode,
> > +				   struct proc_dir_entry **parent, void *data)
> 
> 	Two underscores, please...

Second underscore is more typing, I never understood it.

> > +	parent->nlink++;
> > +	pde = proc_register(parent, pde);
> > +	if (!pde)
> > +		parent->nlink++;
> 
> 	Really?

And ->nlink is a separate bug.