netdev - Re: [PATCH net-next v5 1/4] net/sched: Introduce action ct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190708152805.dul3kgu4csr64fqk@breakpoint.cc>
Date:   Mon, 8 Jul 2019 17:28:05 +0200
From:   Florian Westphal <fw@...len.de>
To:     Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Cc:     Paul Blakey <paulb@...lanox.com>, Jiri Pirko <jiri@...lanox.com>,
        Roi Dayan <roid@...lanox.com>,
        Yossi Kuperman <yossiku@...lanox.com>,
        Oz Shlomo <ozsh@...lanox.com>, netdev@...r.kernel.org,
        David Miller <davem@...emloft.net>,
        Aaron Conole <aconole@...hat.com>,
        Zhike Wang <wangzhike@...com>,
        Rony Efraim <ronye@...lanox.com>, nst-kernel@...hat.com,
        John Hurley <john.hurley@...ronome.com>,
        Simon Horman <simon.horman@...ronome.com>,
        Justin Pettit <jpettit@....org>
Subject: Re: [PATCH net-next v5 1/4] net/sched: Introduce action ct

Marcelo Ricardo Leitner <marcelo.leitner@...il.com> wrote:
> > +	} else { /* NFPROTO_IPV6 */
> > +		enum ip6_defrag_users user = IP6_DEFRAG_CONNTRACK_IN + zone;
> > +
> > +		memset(IP6CB(skb), 0, sizeof(struct inet6_skb_parm));
> > +		err = nf_ct_frag6_gather(net, skb, user);
> 
> This doesn't build without IPv6 enabled.
> ERROR: "nf_ct_frag6_gather" [net/sched/act_ct.ko] undefined!
> 
> We need to (copy and pasted):
> 
> @@ -179,7 +179,9 @@ static int tcf_ct_handle_fragments(struct net *net, struct sk_buff *skb,
>                 local_bh_enable();
>                 if (err && err != -EINPROGRESS)
>                         goto out_free;
> -       } else { /* NFPROTO_IPV6 */
> +       }
> +#if IS_ENABLED(IPV6)
> +       else { /* NFPROTO_IPV6 */
>                 enum ip6_defrag_users user = IP6_DEFRAG_CONNTRACK_IN + zone;

Good catch, but it should be
#if IS_ENABLED(CONFIG_NF_DEFRAG_IPV6)
just like ovs conntrack.c ,