netdev - Re: [PATCH iproute2 1/2] tc: added mask parameter in skbedit action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <85muho5x8g.fsf@mojatatu.com>
Date:   Mon, 08 Jul 2019 12:04:15 -0400
From:   Roman Mashak <mrv@...atatu.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org, kernel@...atatu.com, jhs@...atatu.com,
        xiyou.wangcong@...il.com, jiri@...nulli.us
Subject: Re: [PATCH iproute2 1/2] tc: added mask parameter in skbedit action

Stephen Hemminger <stephen@...workplumber.org> writes:

> On Wed,  3 Jul 2019 19:05:31 -0400
> Roman Mashak <mrv@...atatu.com> wrote:
>
>> +	if (tb[TCA_SKBEDIT_MASK]) {
>> +		print_uint(PRINT_ANY, "mask", "/0x%x",
>> +			   rta_getattr_u32(tb[TCA_SKBEDIT_MASK]));
>
> Why not print in hex with.
>
> 	print_hex(PRINT_ANY, "mask", "/%#x",
> 			rta_getattr_u32(tb[TCA_SKBEDIT_MASK]));

Sure, I will send v2.