netdev - Re: [PATCH net] net: stmmac: Re-work the queue selection for TSO packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190708.124125.1938757647213542470.davem@davemloft.net>
Date:   Mon, 08 Jul 2019 12:41:25 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     Jose.Abreu@...opsys.com
Cc:     netdev@...r.kernel.org, Joao.Pinto@...opsys.com,
        peppe.cavallaro@...com, alexandre.torgue@...com,
        mcoquelin.stm32@...il.com,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        ben@...adent.org.uk
Subject: Re: [PATCH net] net: stmmac: Re-work the queue selection for TSO
 packets

From: Jose Abreu <Jose.Abreu@...opsys.com>
Date: Mon,  8 Jul 2019 14:26:28 +0200

> Ben Hutchings says:
> 	"This is the wrong place to change the queue mapping.
> 	stmmac_xmit() is called with a specific TX queue locked,
> 	and accessing a different TX queue results in a data race
> 	for all of that queue's state.
> 
> 	I think this commit should be reverted upstream and in all
> 	stable branches.  Instead, the driver should implement the
> 	ndo_select_queue operation and override the queue mapping there."
> 
> Fixes: c5acdbee22a1 ("net: stmmac: Send TSO packets always from Queue 0")
> Suggested-by: Ben Hutchings <ben@...adent.org.uk>
> Signed-off-by: Jose Abreu <joabreu@...opsys.com>

Applied and queued up for -stable.