netdev - Re: [EXT] Re: [PATCH net-next v2 4/4] qed*: Add devlink support for configuration attributes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190708144706.46ad7a50@cakuba.netronome.com>
Date:   Mon, 8 Jul 2019 14:47:06 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Sudarsana Reddy Kalluru <skalluru@...vell.com>
Cc:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Michal Kalderon <mkalderon@...vell.com>,
        "Ariel Elior" <aelior@...vell.com>, Jiri Pirko <jiri@...nulli.us>
Subject: Re: [EXT] Re: [PATCH net-next v2 4/4] qed*: Add devlink support for
 configuration attributes.

On Mon, 8 Jul 2019 02:31:15 +0000, Sudarsana Reddy Kalluru wrote:
> > > > > +			Type: u8
> > > > > +			Configuration mode: Permanent
> > > > > +
> > > > > +dcbx_mode		[PORT, DRIVER-SPECIFIC]
> > > > > +			Configure DCBX mode for the device.
> > > > > +			Supported dcbx modes are,
> > > > > +			    Disabled(0), IEEE(1), CEE(2) and
> > > > > Dynamic(3)
> > > > > +			Type: u8
> > > > > +			Configuration mode: Permanent  
> > > >
> > > > Why is this a permanent parameter?
> > > >  
> > > This specifies the dcbx_mode to be configured in non-volatile memory.
> > > The value is persistent and is used in the next load of OS or the mfw.  
> > 
> > And it can't be changed at runtime?  
>
> Run time dcbx params are not affected via this interface, it only
> updates config on permanent storage of the port.

IOW it affects the defaults after boot?  It'd be preferable to have 
the DCB uAPI handle "persistent"/default settings if that's the case.