netdev - Re: [PATCH net-next] net: openvswitch: do not update max_headroom if new headroom is equal to old headroom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190708.160804.2026506853635876959.davem@davemloft.net>
Date:   Mon, 08 Jul 2019 16:08:04 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ap420073@...il.com
Cc:     pshelar@....org, netdev@...r.kernel.org, dev@...nvswitch.org
Subject: Re: [PATCH net-next] net: openvswitch: do not update max_headroom
 if new headroom is equal to old headroom

From: Taehee Yoo <ap420073@...il.com>
Date: Sat,  6 Jul 2019 01:08:09 +0900

> When a vport is deleted, the maximum headroom size would be changed.
> If the vport which has the largest headroom is deleted,
> the new max_headroom would be set.
> But, if the new headroom size is equal to the old headroom size,
> updating routine is unnecessary.
> 
> Signed-off-by: Taehee Yoo <ap420073@...il.com>

I'm not so sure about the logic here and I'd therefore like an OVS expert
to review this.

Thanks.