netdev - Re: [PATCH iproute2-next 2/3] tc: add mpls actions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f202a7ef-909b-1c0c-2a75-10d989b4923f@gmail.com>
Date:   Tue, 9 Jul 2019 14:36:34 -0600
From:   David Ahern <dsahern@...il.com>
To:     Stephen Hemminger <stephen@...workplumber.org>,
        John Hurley <john.hurley@...ronome.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, jiri@...lanox.com,
        xiyou.wangcong@...il.com, willemdebruijn.kernel@...il.com,
        simon.horman@...ronome.com, jakub.kicinski@...ronome.com,
        oss-drivers@...ronome.com
Subject: Re: [PATCH iproute2-next 2/3] tc: add mpls actions

On 7/9/19 11:00 AM, Stephen Hemminger wrote:
> On Tue,  9 Jul 2019 16:59:31 +0100
> John Hurley <john.hurley@...ronome.com> wrote:
> 
>> 	if (!tb[TCA_MPLS_PARMS]) {
>> +		print_string(PRINT_FP, NULL, "%s", "[NULL mpls parameters]");
> 
> This is an error message please just use fprintf(stderr instead
> 

skbedit, nat as 2 examples (and the only 2 I checked) do the print_string.