netdev - Re: [PATCH net-next v2] skbuff: increase verbosity when dumping skb data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190708.193903.1733587425759708535.davem@davemloft.net>
Date:   Mon, 08 Jul 2019 19:39:03 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     willemdebruijn.kernel@...il.com
Cc:     netdev@...r.kernel.org, linyunsheng@...wei.com, willemb@...gle.com
Subject: Re: [PATCH net-next v2] skbuff: increase verbosity when dumping
 skb data

From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Date: Sun,  7 Jul 2019 05:51:55 -0400

> From: Willem de Bruijn <willemb@...gle.com>
> 
> skb_warn_bad_offload and netdev_rx_csum_fault trigger on hard to debug
> issues. Dump more state and the header.
> 
> Optionally dump the entire packet and linear segment. This is required
> to debug checksum bugs that may include bytes past skb_tail_pointer().
> 
> Both call sites call this function inside a net_ratelimit() block.
> Limit full packet log further to a hard limit of can_dump_full (5).
> 
> Based on an earlier patch by Cong Wang, see link below.
> 
> Changes v1 -> v2
>   - dump frag_list only on full_pkt
> 
> Link: https://patchwork.ozlabs.org/patch/1000841/
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>

Nice to finally have this, applied.