netdev - Re: [PATCH net] ipv6: fix static key imbalance in fl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 11 Jul 2019 14:44:11 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com, willemb@...gle.com,
        syzkaller@...glegroups.com
Subject: Re: [PATCH net] ipv6: fix static key imbalance in fl_create()

From: Eric Dumazet <edumazet@...gle.com>
Date: Wed, 10 Jul 2019 06:40:11 -0700

> fl_create() should call static_branch_deferred_inc() only in
> case of success.
> 
> Also we should not call fl_free() in error path, as this could
> cause a static key imbalance.
 ...
> Fixes: 59c820b2317f ("ipv6: elide flowlabel check if no exclusive leases exist")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Acked-by: Willem de Bruijn <willemb@...gle.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>

Applied.