netdev - Re: [PATCH v2] tipc: ensure head->lock is initialised

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190712.153448.2014775769142835466.davem@davemloft.net>
Date:   Fri, 12 Jul 2019 15:34:48 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     chris.packham@...iedtelesis.co.nz
Cc:     jon.maloy@...csson.com, eric.dumazet@...il.com,
        ying.xue@...driver.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH v2] tipc: ensure head->lock is initialised

From: Chris Packham <chris.packham@...iedtelesis.co.nz>
Date: Fri, 12 Jul 2019 10:41:15 +1200

> tipc_named_node_up() creates a skb list. It passes the list to
> tipc_node_xmit() which has some code paths that can call
> skb_queue_purge() which relies on the list->lock being initialised.
> 
> The spin_lock is only needed if the messages end up on the receive path
> but when the list is created in tipc_named_node_up() we don't
> necessarily know if it is going to end up there.
> 
> Once all the skb list users are updated in tipc it will then be possible
> to update them to use the unlocked variants of the skb list functions
> and initialise the lock when we know the message will follow the receive
> path.
> 
> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>

Applied.