netdev - Re: [PATCH net] ppp: mppe: Revert "ppp: mppe: Add softdep to arc4"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190712.230748.1491964275720335140.davem@davemloft.net>
Date:   Fri, 12 Jul 2019 23:07:48 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ebiggers@...nel.org
Cc:     netdev@...r.kernel.org, linux-ppp@...r.kernel.org,
        paulus@...ba.org, linux-crypto@...r.kernel.org, tiwai@...e.de,
        ard.biesheuvel@...aro.org
Subject: Re: [PATCH net] ppp: mppe: Revert "ppp: mppe: Add softdep to arc4"

From: Eric Biggers <ebiggers@...nel.org>
Date: Fri, 12 Jul 2019 16:39:31 -0700

> From: Eric Biggers <ebiggers@...gle.com>
> 
> Commit 0e5a610b5ca5 ("ppp: mppe: switch to RC4 library interface"),
> which was merged through the crypto tree for v5.3, changed ppp_mppe.c to
> use the new arc4_crypt() library function rather than access RC4 through
> the dynamic crypto_skcipher API.
> 
> Meanwhile commit aad1dcc4f011 ("ppp: mppe: Add softdep to arc4") was
> merged through the net tree and added a module soft-dependency on "arc4".
> 
> The latter commit no longer makes sense because the code now uses the
> "libarc4" module rather than "arc4", and also due to the direct use of
> arc4_crypt(), no module soft-dependency is required.
> 
> So revert the latter commit.
> 
> Cc: Takashi Iwai <tiwai@...e.de>
> Cc: Ard Biesheuvel <ard.biesheuvel@...aro.org>
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>

Applied.