netdev - Re: [PATCH net] net: neigh: fix multiple neigh timer scheduling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJ0CqmXZgaHV+NQ6fcaJQvmg3FL-tYfvaz6E9FFyXXGZtHonyg@mail.gmail.com>
Date:   Sat, 13 Jul 2019 17:13:40 +0200
From:   Lorenzo Bianconi <lorenzo.bianconi@...hat.com>
To:     David Miller <davem@...emloft.net>
Cc:     Network Development <netdev@...r.kernel.org>,
        David Ahern <dsahern@...il.com>,
        Marek Majkowski <marek@...udflare.com>
Subject: Re: [PATCH net] net: neigh: fix multiple neigh timer scheduling

>
> From: David Miller <davem@...emloft.net>
> Date: Fri, 12 Jul 2019 15:40:47 -0700 (PDT)
>
> > From: Lorenzo Bianconi <lorenzo.bianconi@...hat.com>
> > Date: Fri, 12 Jul 2019 19:22:51 +0200
> >
> >> Neigh timer can be scheduled multiple times from userspace adding
> >> multiple neigh entries and forcing the neigh timer scheduling passing
> >> NTF_USE in the netlink requests.
> >> This will result in a refcount leak and in the following dump stack:
> >  ...
> >> Fix the issue unscheduling neigh_timer if selected entry is in 'IN_TIMER'
> >> receiving a netlink request with NTF_USE flag set
> >>
> >> Reported-by: Marek Majkowski <marek@...udflare.com>
> >> Fixes: 0c5c2d308906 ("neigh: Allow for user space users of the neighbour table")
> >> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@...hat.com>
> >
> > Applied and queued up for -stable, thanks.
>
> Actually, reverted, you didn't test the build thoroughly as Infiniband
> fails:
>
> drivers/infiniband/core/addr.c: In function ‘dst_fetch_ha’:
> drivers/infiniband/core/addr.c:337:3: error: too few arguments to function ‘neigh_event_send’
>    neigh_event_send(n, NULL);
>    ^~~~~~~~~~~~~~~~

Hi Dave,

sorry for the issue. I will post a v2 fixing it

Regards,
Lorenzo