netdev - Re: [PATCH net v2] net: neigh: fix multiple neigh timer scheduling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190714.121558.1681539034718383341.davem@davemloft.net>
Date:   Sun, 14 Jul 2019 12:15:58 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...il.com
Cc:     lorenzo.bianconi@...hat.com, netdev@...r.kernel.org,
        marek@...udflare.com
Subject: Re: [PATCH net v2] net: neigh: fix multiple neigh timer scheduling

From: David Ahern <dsahern@...il.com>
Date: Sun, 14 Jul 2019 07:58:19 -0600

> On 7/14/19 2:45 AM, Lorenzo Bianconi wrote:
>> @@ -1124,7 +1125,9 @@ int __neigh_event_send(struct neighbour *neigh, struct sk_buff *skb)
>>  
>>  			atomic_set(&neigh->probes,
>>  				   NEIGH_VAR(neigh->parms, UCAST_PROBES));
>> -			neigh->nud_state     = NUD_INCOMPLETE;
>> +			if (check_timer)
>> +				neigh_del_timer(neigh);
> 
> Why not just always call neigh_del_timer and avoid the check_timer flag?
> Let the NUD_IN_TIMER flag handle whether anything needs to be done.

Agreed.