netdev - Re: [PATCH v2 17/35] net/wireless: Use kmemdup rather than duplicating its implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <874l3nr6a4.fsf@codeaurora.org>
Date:   Mon, 15 Jul 2019 12:33:39 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Fuqian Huang <huangfq.daxian@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Solomon Peachy <pizza@...ftnet.org>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 17/35] net/wireless: Use kmemdup rather than duplicating its implementation

Fuqian Huang <huangfq.daxian@...il.com> writes:

> kmemdup is introduced to duplicate a region of memory in a neat way.
> Rather than kmalloc/kzalloc + memcpy, which the programmer needs to
> write the size twice (sometimes lead to mistakes), kmemdup improves
> readability, leads to smaller code and also reduce the chances of mistakes.
> Suggestion to use kmemdup rather than using kmalloc/kzalloc + memcpy.
>
> Signed-off-by: Fuqian Huang <huangfq.daxian@...il.com>

I'm planning to take this.

-- 
Kalle Valo