netdev - Re: [PATCH ipsec] xfrm interface: fix list corruption for x-netns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c4b2d775-82d0-0569-6cb7-c1598dba9a2a@6wind.com>
Date:   Mon, 15 Jul 2019 11:53:11 +0200
From:   Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:     steffen.klassert@...unet.com, davem@...emloft.net
Cc:     netdev@...r.kernel.org, Julien Floret <julien.floret@...nd.com>
Subject: Re: [PATCH ipsec] xfrm interface: fix list corruption for x-netns

Le 10/07/2019 à 15:11, Nicolas Dichtel a écrit :
> dev_net(dev) is the netns of the device and xi->net is the link netns,
> where the device has been linked.
> changelink() must operate in the link netns to avoid a corruption of
> the xfrm lists.
> 
> Note that xi->net and dev_net(xi->physdev) are always the same.
> 
> Before the patch, the xfrmi lists may be corrupted and can later trigger a
> kernel panic.
> 
> Fixes: f203b76d7809 ("xfrm: Add virtual xfrm interfaces")
> Reported-by: Julien Floret <julien.floret@...nd.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> Tested-by: Julien Floret <julien.floret@...nd.com>
Please, drop this one too.


Regards,
Nicolas