lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 15 Jul 2019 17:50:26 +0000 (UTC) From: Kalle Valo <kvalo@...eaurora.org> To: Arnd Bergmann <arnd@...db.de> Cc: Arnd Bergmann <arnd@...db.de>, Miaoqing Pan <miaoqing@...eaurora.org>, "David S. Miller" <davem@...emloft.net>, Rakesh Pillai <pillair@...eaurora.org>, Brian Norris <briannorris@...omium.org>, Balaji Pothunoori <bpothuno@...eaurora.org>, Wen Gong <wgong@...eaurora.org>, Pradeep kumar Chitrapu <pradeepc@...eaurora.org>, Sriram R <srirrama@...eaurora.org>, ath10k@...ts.infradead.org, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, clang-built-linux@...glegroups.com Subject: Re: [PATCH] ath10k: work around uninitialized vht_pfr variable Arnd Bergmann <arnd@...db.de> wrote: > As clang points out, the vht_pfr is assigned to a struct member > without being initialized in one case: > > drivers/net/wireless/ath/ath10k/mac.c:7528:7: error: variable 'vht_pfr' is used uninitialized whenever 'if' condition > is false [-Werror,-Wsometimes-uninitialized] > if (!ath10k_mac_can_set_bitrate_mask(ar, band, mask, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/net/wireless/ath/ath10k/mac.c:7551:20: note: uninitialized use occurs here > arvif->vht_pfr = vht_pfr; > ^~~~~~~ > drivers/net/wireless/ath/ath10k/mac.c:7528:3: note: remove the 'if' if its condition is always true > if (!ath10k_mac_can_set_bitrate_mask(ar, band, mask, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/net/wireless/ath/ath10k/mac.c:7483:12: note: initialize the variable 'vht_pfr' to silence this warning > u8 vht_pfr; > > Add an explicit but probably incorrect initialization here. > I suspect we want a better fix here, but chose this approach to > illustrate the issue. > > Fixes: 8b97b055dc9d ("ath10k: fix failure to set multiple fixed rate") > Signed-off-by: Arnd Bergmann <arnd@...db.de> > Reviewed-by: Nathan Chancellor <natechancellor@...il.com> Patch applied to wireless-drivers.git, thanks. ff414f31ce37 ath10k: work around uninitialized vht_pfr variable -- https://patchwork.kernel.org/patch/11034993/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists