netdev - Re: [PATCH] ethtool: igb: dump RR2DCDELAY register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cab2d7f27cc57a0bc680bd5f7e483461b841b96b.camel@gmail.com>
Date:   Mon, 15 Jul 2019 14:01:40 +0300
From:   Artem Bityutskiy <dedekind1@...il.com>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     "John W . Linville" <linville@...driver.com>,
        netdev@...r.kernel.org
Subject: Re: [PATCH] ethtool: igb: dump RR2DCDELAY register

On Mon, 2019-07-15 at 11:13 +0200, Michal Kubecek wrote:
> > +	/*
> > +	 * Starting from kernel version 5.3 the registers dump buffer grew from
> > +	 * 739 4-byte words to 740 words, and word 740 contains the RR2DCDLAY
> 
> nit: "E" missing here:                                                    ^

Fixed and sent out v2.

> > +	fprintf(stdout,
> > +		"0x05BF4: RR2DCDELAY  (Max. DMA read delay)            0x%08X\n",
> > +		regs_buff[739]);
> 
> Showing a delay as hex number doesn't seem very user friendly but that
> also applies to many existing registers so it's probably better to be
> consistent and perhaps do an overall cleanup later.

Agree.

Thanks!