netdev - Re: [PATCH v3 17/24] ethernet: remove redundant memset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190715.110646.1964036532467569670.davem@davemloft.net>
Date:   Mon, 15 Jul 2019 11:06:46 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     huangfq.daxian@...il.com
Cc:     jcliburn@...il.com, chris.snook@...il.com,
        michael.chan@...adcom.com, vishal@...lsio.com, fugang.duan@....com,
        cooldavid@...ldavid.org, mlindner@...vell.com,
        stephen@...workplumber.org, tariqt@...lanox.com,
        saeedm@...lanox.com, leon@...nel.org, jiri@...lanox.com,
        idosch@...lanox.com, jdmason@...zu.us, manishc@...vell.com,
        rahulv@...vell.com, GR-Linux-NIC-Dev@...vell.com, chessman@....org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-rdma@...r.kernel.org
Subject: Re: [PATCH v3 17/24] ethernet: remove redundant memset

From: Fuqian Huang <huangfq.daxian@...il.com>
Date: Mon, 15 Jul 2019 11:19:11 +0800

> kvzalloc already zeroes the memory during the allocation.
> pci_alloc_consistent calls dma_alloc_coherent directly.
> In commit 518a2f1925c3
> ("dma-mapping: zero memory returned from dma_alloc_*"),
> dma_alloc_coherent has already zeroed the memory.
> So the memset after these function is not needed.
> 
> Signed-off-by: Fuqian Huang <huangfq.daxian@...il.com>

Applied.