lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 15 Jul 2019 17:15:15 -0700 From: Jakub Kicinski <jakub.kicinski@...ronome.com> To: Stephen Hemminger <stephen@...workplumber.org> Cc: Vedang Patel <vedang.patel@...el.com>, netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us, vinicius.gomes@...el.com, leandro.maciel.dorileo@...el.com, m-karicheri2@...com, dsahern@...il.com Subject: Re: [PATCH iproute2 net-next v3 2/5] taprio: Add support for setting flags On Mon, 15 Jul 2019 16:37:43 -0700, Stephen Hemminger wrote: > On Mon, 15 Jul 2019 15:51:41 -0700 > Vedang Patel <vedang.patel@...el.com> wrote: > > @@ -442,6 +458,11 @@ static int taprio_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr *opt) > > > > print_string(PRINT_ANY, "clockid", "clockid %s", get_clock_name(clockid)); > > > > + if (tb[TCA_TAPRIO_ATTR_FLAGS]) { > > + taprio_flags = rta_getattr_u32(tb[TCA_TAPRIO_ATTR_FLAGS]); > > + print_uint(PRINT_ANY, "flags", " flags %x", taprio_flags); > > + } >[...] > 3. Use the print_0xhex() instead of print_uint() for hex values. The difference > is that in the JSON output, print_uint would be decimal but the print_0xhex > is always hex. And use "flags %#x" so that it is clear you are printing flags in hex. In my humble personal experience scripting tests using iproute2 and bpftool with Python I found printing the "hex string" instead of just outputing the integer value counter productive :( Even tho it looks better to the eye, JSON is primarily for machine processing and hex strings have to be manually converted.
Powered by blists - more mailing lists