netdev - Re: [PATCH iproute2 net-next v3 3/5] taprio: add support for setting txtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9CBE2F6E-BA4B-45E7-9368-A5D743E472FD@intel.com>
Date:   Tue, 16 Jul 2019 01:17:35 +0000
From:   "Patel, Vedang" <vedang.patel@...el.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        "Gomes, Vinicius" <vinicius.gomes@...el.com>,
        "Dorileo, Leandro" <leandro.maciel.dorileo@...el.com>,
        "jakub.kicinski@...ronome.com" <jakub.kicinski@...ronome.com>,
        "m-karicheri2@...com" <m-karicheri2@...com>,
        "dsahern@...il.com" <dsahern@...il.com>
Subject: Re: [PATCH iproute2 net-next v3 3/5] taprio: add support for
 setting txtime_delay.



> On Jul 15, 2019, at 4:38 PM, Stephen Hemminger <stephen@...workplumber.org> wrote:
> 
> On Mon, 15 Jul 2019 15:51:42 -0700
> Vedang Patel <vedang.patel@...el.com> wrote:
> 
>> +			if (get_s32(&txtime_delay, *argv, 0)) {
> 
> Is txtime_delay of a negative value meaningful?

No, txtime-delay should always be a positive value. I will change this to u32 here.  I will also make the corresponding changes in the kernel and send the updated patch. 

Thanks,
Vedang