netdev - Re: [PATCH net] be2net: Signal that the device cannot transmit during reconfiguration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190716.124147.446749376298800402.davem@davemloft.net>
Date:   Tue, 16 Jul 2019 12:41:47 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     bpoirier@...e.com
Cc:     sathya.perla@...adcom.com, ajit.khaparde@...adcom.com,
        sriharsha.basavapatna@...adcom.com, somnath.kotur@...adcom.com,
        fyang@...e.com, saeedm@...lanox.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] be2net: Signal that the device cannot transmit
 during reconfiguration

From: Benjamin Poirier <bpoirier@...e.com>
Date: Tue, 16 Jul 2019 17:16:55 +0900

> While changing the number of interrupt channels, be2net stops adapter
> operation (including netif_tx_disable()) but it doesn't signal that it
> cannot transmit. This may lead dev_watchdog() to falsely trigger during
> that time.
> 
> Add the missing call to netif_carrier_off(), following the pattern used in
> many other drivers. netif_carrier_on() is already taken care of in
> be_open().
> 
> Signed-off-by: Benjamin Poirier <bpoirier@...e.com>

Applied.