netdev - Re: [PATCH net-next v1] fix: taprio: Change type of txtime-delay parameter to u32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <D18998A5-4B08-4F27-897F-A34B7C15684F@intel.com>
Date:   Wed, 17 Jul 2019 17:32:10 +0000
From:   "Patel, Vedang" <vedang.patel@...el.com>
To:     David Miller <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "Gomes, Vinicius" <vinicius.gomes@...el.com>,
        "l@...ileo.org" <l@...ileo.org>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        "Murali Karicheri" <m-karicheri2@...com>,
        Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        Eric Dumazet <eric.dumazet@...il.com>,
        "Brown, Aaron F" <aaron.f.brown@...el.com>,
        Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH net-next v1] fix: taprio: Change type of txtime-delay
 parameter to u32



> On Jul 16, 2019, at 2:19 PM, David Miller <davem@...emloft.net> wrote:
> 
> From: Vedang Patel <vedang.patel@...el.com>
> Date: Tue, 16 Jul 2019 12:52:18 -0700
> 
>> During the review of the iproute2 patches for txtime-assist mode, it was
>> pointed out that it does not make sense for the txtime-delay parameter to
>> be negative. So, change the type of the parameter from s32 to u32.
>> 
>> Fixes: 4cfd5779bd6e ("taprio: Add support for txtime-assist mode")
>> Reported-by: Stephen Hemminger <stephen@...workplumber.org>
>> Signed-off-by: Vedang Patel <vedang.patel@...el.com>
> 
> You should have targetted this at 'net' as that's the only tree open
> right now.
> 
> I'll apply this.

Sorry about that.

I will keep this in mind from next time. 

Thanks,
Vedang