netdev - Re: [PATCH] bnx2x: Prevent load reordering in tx completion processing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 17 Jul 2019 12:00:45 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     brking@...ux.vnet.ibm.com
Cc:     GR-everest-linux-l2@...vell.com, skalluru@...vell.com,
        aelior@...vell.com, netdev@...r.kernel.org
Subject: Re: [PATCH] bnx2x: Prevent load reordering in tx completion
 processing

From: Brian King <brking@...ux.vnet.ibm.com>
Date: Mon, 15 Jul 2019 16:41:50 -0500

> This patch fixes an issue seen on Power systems with bnx2x which results
> in the skb is NULL WARN_ON in bnx2x_free_tx_pkt firing due to the skb
> pointer getting loaded in bnx2x_free_tx_pkt prior to the hw_cons
> load in bnx2x_tx_int. Adding a read memory barrier resolves the issue.
> 
> Signed-off-by: Brian King <brking@...ux.vnet.ibm.com>

Marvell folks, please review.