netdev - Re: [PATCH v3 1/3] kernel/notifier.c: avoid duplicate registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5a84e4b6-902d-a2ab-8416-2320bfab2a52@virtuozzo.com>
Date:   Wed, 17 Jul 2019 14:19:13 +0300
From:   Vasily Averin <vvs@...tuozzo.com>
To:     Xiaoming Ni <nixiaoming@...wei.com>, adobriyan@...il.com,
        akpm@...ux-foundation.org, anna.schumaker@...app.com,
        arjan@...ux.intel.com, bfields@...ldses.org,
        chuck.lever@...cle.com, davem@...emloft.net,
        gregkh@...uxfoundation.org, jlayton@...nel.org, luto@...nel.org,
        mingo@...nel.org, Nadia.Derbey@...l.net,
        paulmck@...ux.vnet.ibm.com, semen.protsenko@...aro.org,
        stable@...nel.org, stern@...land.harvard.edu, tglx@...utronix.de,
        torvalds@...ux-foundation.org, trond.myklebust@...merspace.com,
        viresh.kumar@...aro.org
Cc:     alex.huangjianhui@...wei.com, dylix.dailei@...wei.com,
        linux-kernel@...r.kernel.org, linux-nfs@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH v3 1/3] kernel/notifier.c: avoid duplicate registration

On 7/10/19 6:09 AM, Xiaoming Ni wrote:
> Registering the same notifier to a hook repeatedly can cause the hook
> list to form a ring or lose other members of the list.
> 
> case1: An infinite loop in notifier_chain_register() can cause soft lockup
>         atomic_notifier_chain_register(&test_notifier_list, &test1);
>         atomic_notifier_chain_register(&test_notifier_list, &test1);
>         atomic_notifier_chain_register(&test_notifier_list, &test2);
> 
> case2: An infinite loop in notifier_chain_register() can cause soft lockup
>         atomic_notifier_chain_register(&test_notifier_list, &test1);
>         atomic_notifier_chain_register(&test_notifier_list, &test1);
>         atomic_notifier_call_chain(&test_notifier_list, 0, NULL);
> 
> case3: lose other hook test2
>         atomic_notifier_chain_register(&test_notifier_list, &test1);
>         atomic_notifier_chain_register(&test_notifier_list, &test2);
>         atomic_notifier_chain_register(&test_notifier_list, &test1);
> 
> case4: Unregister returns 0, but the hook is still in the linked list,
>         and it is not really registered. If you call notifier_call_chain
>         after ko is unloaded, it will trigger oops.
> 
> If the system is configured with softlockup_panic and the same
> hook is repeatedly registered on the panic_notifier_list, it
> will cause a loop panic.
> 
> Add a check in notifier_chain_register() to avoid duplicate registration
> 
> Signed-off-by: Xiaoming Ni <nixiaoming@...wei.com>
Reviewed-by: Vasily Averin <vvs@...tuozzo.com>
> ---
>  kernel/notifier.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/kernel/notifier.c b/kernel/notifier.c
> index d9f5081..30bedb8 100644
> --- a/kernel/notifier.c
> +++ b/kernel/notifier.c
> @@ -23,7 +23,10 @@ static int notifier_chain_register(struct notifier_block **nl,
>  		struct notifier_block *n)
>  {
>  	while ((*nl) != NULL) {
> -		WARN_ONCE(((*nl) == n), "double register detected");
> +		if (unlikely((*nl) == n)) {
> +			WARN(1, "double register detected");
> +			return 0;
> +		}
>  		if (n->priority > (*nl)->priority)
>  			break;
>  		nl = &((*nl)->next);
>